Skip to content

chore: upgrade oxc dependencies from 0.117.0 to 0.137.0 - #46

Merged
TheUncharted merged 1 commit into
masterfrom
chore/upgrade-oxc-deps
Jun 20, 2026
Merged

chore: upgrade oxc dependencies from 0.117.0 to 0.137.0#46
TheUncharted merged 1 commit into
masterfrom
chore/upgrade-oxc-deps

Conversation

@TheUncharted

@TheUncharted TheUncharted commented Jun 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

Summary

Upgrades all oxc dependencies from 0.117.0 to 0.137.0 to stay current with the upstream parser ecosystem.
One breaking API change was addressed: ParserReturn.errors was renamed to ParserReturn.diagnostics.

Changes

  • Bump oxc_parser, oxc_ast, oxc_allocator, oxc_span, oxc_syntax from 0.117.0 to 0.137.0
  • Update ParserReturn.errors → ParserReturn.diagnostics in crates/zapcode-core/src/parser/mod.rs

Test plan

  • Unit tests pass (cargo test)
  • CI passes

Related issues

Summary by CodeRabbit

Release Notes

  • Bug Fixes

    • Improved error detection and diagnostic reporting in parsing operations, providing more detailed error information when issues occur.

  • Chores

    • Updated parser dependencies to the latest stable versions for enhanced reliability, improved performance, and better overall system stability.

@TheUncharted
chore: upgrade oxc dependencies from 0.117.0 to 0.137.0
e29e891 
- Upgrade oxc_parser, oxc_ast, oxc_allocator, oxc_span, oxc_syntax
- Fix breaking change: ParserReturn.errors renamed to diagnostics
- All 338 tests pass
@coderabbitai

coderabbitai Bot commented Jun 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 424ce998-2044-41f1-a2b6-714ad3a3f0c9

📥 Commits

Reviewing files that changed from the base of the PR and between 1bf3aaa and e29e891.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • Cargo.toml
  • crates/zapcode-core/src/parser/mod.rs
📝 Walkthrough

Walkthrough

Five oxc_* workspace dependencies are bumped from version 0.117.0 to 0.137.0 in Cargo.toml. The parse function in the core parser module is updated to reference ret.diagnostics instead of ret.errors for both the empty-check guard and message collection when constructing a ZapcodeError::ParseError.

Changes

oxc Upgrade and Parser Diagnostics Adaptation

Layer / File(s) Summary
oxc dependency bump and diagnostics field rename
Cargo.toml, crates/zapcode-core/src/parser/mod.rs		 oxc_parser, oxc_ast, oxc_allocator, oxc_span, and oxc_syntax are bumped from 0.117.0 to 0.137.0. The parse function's error path is updated from ret.errors to ret.diagnostics for both the emptiness check and message string collection.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: upgrading oxc dependencies from version 0.117.0 to 0.137.0, which aligns with the Cargo.toml changes shown in the raw summary.
Description check ✅ Passed The pull request description includes all required sections from the template: Summary, Changes, and Test plan with appropriate checkboxes. The description clearly documents the upgrade and the breaking API change fix.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/upgrade-oxc-deps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results

    Updating crates.io index
 Downloading crates ...
  Downloaded hashbrown v0.17.1
  Downloaded oxc_span v0.137.0
  Downloaded oxc_syntax v0.137.0
  Downloaded oxc_str v0.137.0
  Downloaded oxc_index v5.0.0
  Downloaded oxc_regular_expression v0.137.0
  Downloaded oxc_ecmascript v0.137.0
  Downloaded oxc-miette-derive v3.0.0
  Downloaded oxc_allocator v0.137.0
  Downloaded oxc-miette v3.0.0
  Downloaded oxc_diagnostics v0.137.0
  Downloaded oxc_parser v0.137.0
  Downloaded oxc_ast v0.137.0
  Downloaded oxc_ast_macros v0.137.0
  Downloaded oxc_data_structures v0.137.0
  Downloaded oxc_estree v0.137.0
   Compiling hashbrown v0.17.1
   Compiling oxc-miette-derive v3.0.0
   Compiling oxc_data_structures v0.137.0
   Compiling oxc_estree v0.137.0
   Compiling oxc_ast_macros v0.137.0
   Compiling oxc_allocator v0.137.0
   Compiling oxc_index v5.0.0
   Compiling hashbrown v0.16.1
   Compiling oxc_str v0.137.0
   Compiling indexmap v2.13.0
   Compiling oxc-miette v3.0.0
   Compiling oxc_span v0.137.0
   Compiling oxc_diagnostics v0.137.0
   Compiling oxc_regular_expression v0.137.0
   Compiling oxc_syntax v0.137.0
   Compiling oxc_ast v0.137.0
   Compiling oxc_ecmascript v0.137.0
   Compiling oxc_parser v0.137.0
   Compiling zapcode-core v1.5.2 (/home/runner/work/zapcode/zapcode/crates/zapcode-core)
    Finished `bench` profile [optimized] target(s) in 27.08s
     Running unittests src/lib.rs (target/release/deps/zapcode_core-1dc9f767e4a550b4)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running benches/execution.rs (target/release/deps/execution-601473f0011e8d52)
Timer precision: 20 ns
execution                  fastest       │ slowest       │ median        │ mean          │ samples │ iters
├─ array_creation          3.915 µs      │ 63.21 µs      │ 4.15 µs       │ 5.165 µs      │ 100     │ 100
├─ async_map_3             13.59 µs      │ 57.32 µs      │ 14.21 µs      │ 15.51 µs      │ 100     │ 100
├─ fibonacci_10            194.3 µs      │ 238.9 µs      │ 197.8 µs      │ 201.2 µs      │ 100     │ 100
├─ function_call           6.509 µs      │ 10.59 µs      │ 6.825 µs      │ 6.921 µs      │ 100     │ 100
├─ loop_100                111.5 µs      │ 135.7 µs      │ 113.7 µs      │ 114.8 µs      │ 100     │ 100
├─ object_creation         7.59 µs       │ 16.92 µs      │ 7.851 µs      │ 8.052 µs      │ 100     │ 100
├─ promise_all_3           10.26 µs      │ 20.89 µs      │ 10.71 µs      │ 10.92 µs      │ 100     │ 100
├─ promise_catch_resolved  6.519 µs      │ 17.62 µs      │ 6.689 µs      │ 6.925 µs      │ 100     │ 100
├─ promise_resolve_await   4.536 µs      │ 6.058 µs      │ 4.696 µs      │ 4.747 µs      │ 100     │ 100
├─ promise_then_chain_3    13.48 µs      │ 26.73 µs      │ 14.33 µs      │ 14.76 µs      │ 100     │ 100
├─ promise_then_single     7.791 µs      │ 17.22 µs      │ 8.272 µs      │ 8.394 µs      │ 100     │ 100
├─ simple_expression       3.575 µs      │ 5.758 µs      │ 3.76 µs       │ 3.804 µs      │ 100     │ 100
├─ string_concat           4.235 µs      │ 7.2 µs        │ 4.391 µs      │ 4.453 µs      │ 100     │ 100
├─ template_literal        4.516 µs      │ 14.51 µs      │ 4.782 µs      │ 4.962 µs      │ 100     │ 100
╰─ variable_arithmetic     4.556 µs      │ 6.94 µs       │ 4.847 µs      │ 4.883 µs      │ 100     │ 100

@TheUncharted
TheUncharted merged commit 95ebed9 into master Jun 20, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@TheUncharted